-
Notifications
You must be signed in to change notification settings - Fork 448
Clarify endIndex
behavior of partitioningIndex(where:)
in documentation (Resolves #170)
#171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
natecook1000
merged 4 commits into
apple:main
from
mdznr:170_partitioningIndex_documentation
Dec 16, 2021
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0830109
Specifically document `endIndex` return value behavior
mdznr ac99505
Clarify `partitioningIndex(where:)` behavior in inline documentation
mdznr 6b1c8e6
Add `partitioningIndex(where:)` unit tests for empty input
mdznr dd5a49b
Add `partitioningIndex(where:)` unit tests where all elements in a co…
mdznr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,8 +168,8 @@ extension MutableCollection where Self: BidirectionalCollection { | |
//===----------------------------------------------------------------------===// | ||
|
||
extension Collection { | ||
/// Returns the index of the first element in the collection that matches | ||
/// the predicate. | ||
/// Returns the start index of the partition of a collection that matches | ||
/// the given predicate. | ||
/// | ||
/// The collection must already be partitioned according to the predicate. | ||
/// That is, there should be an index `i` where for every element in | ||
|
@@ -179,7 +179,8 @@ extension Collection { | |
/// - Parameter belongsInSecondPartition: A predicate that partitions the | ||
/// collection. | ||
/// - Returns: The index of the first element in the collection for which | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I’m still a bit unsure about this sentence. It almost sounds like the first time that |
||
/// `predicate` returns `true`. | ||
/// `predicate` returns `true`, or `endIndex` if there are no elements | ||
/// for which `predicate` returns `true`. | ||
/// | ||
/// - Complexity: O(log *n*), where *n* is the length of this collection if | ||
/// the collection conforms to `RandomAccessCollection`, otherwise O(*n*). | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.