Skip to content

Implement distance(from:to:) for Chain #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

Implement distance(from:to:) for Chain #3

merged 2 commits into from
Oct 12, 2020

Conversation

timvermeulen
Copy link
Contributor

@timvermeulen timvermeulen commented Oct 8, 2020 •
edited
Loading

This PR implements the distance(from:to:) method that was missing from Chain.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Copy link
Member

Looks great, @timvermeulen — thanks!

@natecook1000 natecook1000 merged commit c67dd34 into apple:main Oct 12, 2020
@timvermeulen timvermeulen deleted the chain-distance-from-to branch October 15, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timvermeulen @natecook1000