-
Notifications
You must be signed in to change notification settings - Fork 448
Add Sequence.firstNonNil(_:) #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
2895485
3a13c14
ff69eae
a9e2295
fa09d75
5a0feb4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# FirstNonNil | ||
|
||
[[Source](https://github.com/apple/swift-algorithms/blob/main/Sources/Algorithms/FirstNonNil.swift) | | ||
[Tests](https://github.com/apple/swift-algorithms/blob/main/Tests/SwiftAlgorithmsTests/FirstNonNilTests.swift)] | ||
|
||
Retrieves the first `.some` encountered while applying the given transform. | ||
|
||
This operation is available through the `firstNonNil(_:)` method on any sequence. | ||
|
||
```swift | ||
let value = ["A", "B", "10"].firstNonNil { Int($0) } | ||
// value == .some(10) | ||
// | ||
let noValue = ["A", "B", "C"].firstNonNil { Int($0) } | ||
// noValue == .none | ||
``` | ||
|
||
|
||
This method is analogous to `first(where:)` in how it only consumes values until | ||
a `.some` is found, unlike using lazy operators, which will load any sequence into a collection | ||
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you be a little more explicit here about why this method is useful? I think @timvermeulen explained it very well in the corresponding issue (about using the alternative being unintentionally not lazy in certain situations), and if you get his permission, that might be a helpful piece of information for users. |
||
before evaluating its transforms lazily. | ||
|
||
## Detailed Design | ||
|
||
The `firstNonNil(_:)` method is added as an extension method on the `Sequence` | ||
protocol: | ||
|
||
```swift | ||
public extension Sequence { | ||
func firstNonNil<Result>(_ transform: (Element) throws -> Result?) | ||
rethrows -> Result? | ||
} | ||
|
||
``` | ||
|
||
### Naming | ||
|
||
This method’s name was selected for its comprehensibility. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don’t think this sentence adds much to the reader. If this section isn’t mandatory, then it can be deleted. If it is mandatory, then you’ll need to explain why this name has good “comprehensibility.” Perhaps @natecook1000 can help you to explain since he made the choice. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be great to capture the other names that came up in the issue discussion here. Why was |
||
|
||
### Comparison with other languages | ||
|
||
**Scala**: Scala provides a `collectFirst` function that finds the first element | ||
in a collection for which a partial function is defined. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There were a few other precedents mentioned in the corresponding issue. Could you please include them here? Ideally, we’d look around a bit more and really study the landscape here so that we can be sure we’ve picked a good name. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the Swift Algorithms open source project | ||
// | ||
// Copyright (c) 2020 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
//===----------------------------------------------------------------------===// | ||
// firstNonNil(_:) | ||
//===----------------------------------------------------------------------===// | ||
|
||
public extension Sequence { | ||
/// Returns the first element in `self` that `transform` maps to a `.some`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This method doesn't return the first element, it returns the mapped result. Can you update this wording and include an example demonstrating the usage? |
||
func firstNonNil<Result>(_ transform: (Element) throws -> Result?) rethrows -> Result? { | ||
Qata marked this conversation as resolved.
Show resolved
Hide resolved
|
||
for value in self { | ||
if let value = try transform(value) { | ||
return value | ||
} | ||
} | ||
return nil | ||
} | ||
Comment on lines
+21
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: For source files we use 2-space indents. |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the Swift Algorithms open source project | ||
// | ||
// Copyright (c) 2020 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
import XCTest | ||
import Algorithms | ||
|
||
final class FirstNonNilTests: XCTestCase { | ||
func testFirstNonNil() { | ||
XCTAssertNil([].firstNonNil { $0 }) | ||
XCTAssertNil(["A", "B", "C"].firstNonNil { Int($0) }) | ||
XCTAssertNil(["A", "B", "C"].firstNonNil { _ in nil }) | ||
XCTAssertEqual(["A", "B", "10"].firstNonNil { Int($0) }, 10) | ||
XCTAssertEqual(["20", "B", "10"].firstNonNil { Int($0) }, 20) | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.