Rename chained(with:) to chain(_:_:)

[natecook1000]

Description

This follows a forum discussion about the chained(with:) name. The old names are preserved as deprecated symbols.

Detailed Design

The new version of chain looks like this:

func chain<S1, S2>(_ s1: S1, _ s2: S2) -> Chain2<S1, S2>

Documentation Plan

Updated the symbol documentation, guide, and README.

Test Plan

Updated existing tests to use the new name.

Source Impact

This deprecates the chained(with:) method and the Chain2 type.

Checklist

• I've added at least one test that validates that my change is working, if appropriate
• I've followed the code style of the rest of the project
• I've read the Contribution Guidelines
• I've updated the documentation if necessary

[timvermeulen]

I believe this conformance should be removed altogether with chain being a free function.

[natecook1000]

Yes! Another wrinkle in the various keep-it-lazy shenanigans.

[tonyarnold]

This is a harmful change for how I was using the code, ie:

seq1
    .chained(with: seq2)
    .chained(with: seq3)
    .chained(with: seq4)

Is there a good reason to remove the older variation beyond contributor happiness?

[mdznr]

Just so that it is easier to find the relevant forum thread for anyone reading this later, here it is: https://forums.swift.org/t/naming-of-chained-with/40999