Skip to content

Cleaning up some comments #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Cleaning up some comments #49

merged 1 commit into from
Dec 2, 2020

Conversation

markuswntr
Copy link
Contributor

This PR contains a few minor changes to comments, namely:

  • Combinations.swift contained an invalid source code example
  • Rotate.swift was missing the definition of n (for (O(n))
  • Trim.swifts formatting diverged from the rest of the project
    • Comments did not break on or before line # 80
    • Replaced the delimiter names parameters and complexity with Parameters and Complexity respectively
    • Replaced `O(n)` and `n` with O(*n*) and *n* respectively

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Copy link
Member

Thanks for taking care of these, @markuswntr! 👏

@natecook1000 natecook1000 merged commit 7af7ac2 into apple:main Dec 2, 2020
@markuswntr markuswntr deleted the patch-1 branch December 2, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants