Internally add Collection.endOfPrefix(while:) and BidirectionalCollection.startOfSuffix(while:) #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
approved these changes
Mar 9, 2021
| return self[Range(uncheckedBounds: (sliceStart, sliceStart))] | ||
| let start = try endOfPrefix(while: predicate) | ||
| let end = try self[start...].startOfSuffix(while: predicate) | ||
| return self[start..<end] |
karwa
reviewed
Mar 10, 2021
| /// be called again. | ||
| /// | ||
| /// - Complexity: O(*n*), where *n* is the length of the collection. | ||
| @usableFromInline |
There was a problem hiding this comment.
This PR looks really nice, but I think these should be inlinable rather than just usableFromInline. We want the compiler to be able to specialise them for a particular predicate closure (and for generic specialisation for the collection, of course)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally adds the
endOfPrefix(while:)method toCollectionand thestartOfSuffix(while:)method toBidirectionalCollection.These methods return the same values as
prefix(while: predicate).endIndexandsuffix(while: predicate).startIndex, respectively. We're adding them as internal methods for now because we're already using this functionality in several places throughout the package, but it's unclear whether these are the names we want to stick with.Checklist