Skip to content

Windows: migrate to CRT from MSVCRT #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

compnerd
Copy link
Collaborator

@compnerd compnerd commented Oct 18, 2020

The Windows environment calls the library CRT. This also enables the
removal of the visualc module from the Swift SDK overlay.

Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

The Windows environment calls the library `CRT`.  This also enables the
removal of the `visualc` module from the Swift SDK overlay.
@compnerd
Copy link
Collaborator Author

@swift-ci please test

@compnerd
Copy link
Collaborator Author

This needs to be synchronized with swiftlang/swift#34299

@compnerd
Copy link
Collaborator Author

All associated changes for that change are now merged

@natecook1000 natecook1000 merged commit 8492882 into apple:main Oct 20, 2020
@compnerd compnerd deleted the CRT branch October 20, 2020 18:14
CypherPoet pushed a commit to CypherPoet/swift-argument-parser that referenced this pull request Oct 24, 2020
The Windows environment calls the library `CRT`.  This also enables the
removal of the `visualc` module from the Swift SDK overlay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants