Skip to content

Don't error when decoding optional unparsed values #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

natecook1000
Copy link
Member

We're newly able to decode actual optional types due to allowing unparsed variable properties. "Normal" optional values are still wrapped in non-optional property wrappers, so ArgumentDecoder didn't need to handle optional values until now. Fixes #285.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

We're newly able to decode actual optional types due to allowing
unparsed variable properties. "Normal" optional values are still
wrapped in non-optional property wrappers, so ArgumentDecoder didn't
need to handle optional values until now. Fixes #285
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit 380eb72 into main Mar 7, 2021
@natecook1000 natecook1000 deleted the nate/nested_unparsed_types branch March 7, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.4.0 seems to think there's an argument var that doesn't actually exist
1 participant