Skip to content

Fix compile failure on iOS for Mac Catalyst support #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

imxieyi
Copy link
Contributor

@imxieyi imxieyi commented Sep 12, 2021

This PR fixes compile failure on iOS, which happens if you are adding CLI support for a Mac Catalyst app. Specifically, it fixes:

'sortedKeys' is only available in iOS 11.0 or newer

Checklist

  • [N/A] I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • [N/A] I've updated the documentation if necessary

@rauhul
Copy link
Contributor

rauhul commented Sep 13, 2021

@swift-ci please test

@rauhul
Copy link
Contributor

rauhul commented Sep 13, 2021

It may be worth adding annotations for all platforms just in-case. https://developer.apple.com/documentation/foundation/jsonserialization/writingoptions/2888322-sortedkeys

@rauhul
Copy link
Contributor

rauhul commented Sep 13, 2021

@swift-ci please test

@natecook1000 natecook1000 merged commit afe0b95 into apple:main Sep 13, 2021
@natecook1000
Copy link
Member

Thanks, @imxieyi! 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants