Skip to content

Fix Repeat's default endless printing #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Fix Repeat's default endless printing #432

wants to merge 0 commits into from

Conversation

KeithBird
Copy link
Contributor

@KeithBird KeithBird commented Mar 24, 2022 •
edited
Loading

To prevent newbies from being scared off by endless printing in the terminal, I changed the default value of Repeat.count from .max to 2.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@KeithBird KeithBird changed the title Fix Repeat's unstoppable printing Fix Repeat's endless printing Mar 24, 2022
@KeithBird KeithBird changed the title Fix Repeat's endless printing Fix Repeat's default endless printing Mar 24, 2022
@rauhul
Copy link
Contributor

rauhul commented Mar 25, 2022

@swift-ci please test

@rauhul rauhul requested review from natecook1000 and rauhul March 25, 2022 01:27
rauhul
rauhul approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change to me

@KeithBird KeithBird closed this Mar 27, 2022
@KeithBird KeithBird mentioned this pull request Mar 27, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauhul rauhul rauhul approved these changes

@natecook1000 natecook1000 Awaiting requested review from natecook1000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KeithBird @rauhul