Skip to content

Improve failure message for backdeployed AsyncParsableCommand #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

natecook1000
Copy link
Member

@natecook1000 natecook1000 commented Jan 24, 2023

When an executable with asynchronous commands is backdeployed, the compiler chooses the synchronous main() unless a minimum availability target is provided for the root command type. This changes the error message provided when the incorrect main() function is called to direct the tool's author to a correct solution.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

When an executable with asynchronous commands is backdeployed,
the compiler chooses the synchronous `main()` unless a minimum
availability target is provided for the root command type. This
changes the error message provided when the incorrect `main()`
function is called to direct the tool's author to a correct
solution.
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit 478c2df into apple:main Jan 27, 2023
@natecook1000 natecook1000 deleted the min_platform_message branch February 9, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant