build: bump minimum CMake requirement #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the CMake requirement to 3.19 as Swift requires 3.19.x to build. The upgrade allows us to remove workarounds that we were carrying for older CMake compatibility.
|
@swift-ci please test |
|
CC: @natecook1000 @rauhul |
|
FWIW I have no issues with you directly merging cmake changes |
bnbarham
reviewed
Dec 8, 2023
| set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib) | ||
| set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib) | ||
| endif() | ||
| list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules) |
There was a problem hiding this comment.
Hmm, that is a good point 🤔. How did CI get away with this?
There was a problem hiding this comment.
Ah, looking at logs CI is using SPM, not CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the CMake requirement to 3.19 as Swift requires 3.19.x to build. The upgrade allows us to remove workarounds that we were carrying for older CMake compatibility.