Skip to content

[WIP] Add a few more guides #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 18, 2022
Merged

[WIP] Add a few more guides #64

merged 30 commits into from
Mar 18, 2022

Conversation

phausler
Copy link
Member

@phausler phausler commented Mar 1, 2022

This is a work in progress to lay the groundwork for guides for chunking, collection initializers, compacted, debounce, joined, reductions, remove duplicates, throttle and timer.

@phausler phausler requested a review from kperryua March 1, 2022 08:00
@phausler phausler requested a review from invalidname March 11, 2022 19:30
@phausler phausler force-pushed the pr/guides branch 5 times, most recently from 206b5a0 to 936ac5b Compare March 14, 2022 21:36
Copy link
Contributor

@invalidname invalidname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a fairly light editorial pass over these, avoiding Chunked.md and Joined.md at Kevin's request. Nearly all of my feedback is in the form of suggestions, so you can apply them more easily.

Feel free to reach out to me if you have questions, or if you'd like me to take another look.

Copy link
Contributor

@invalidname invalidname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a fairly light editorial pass over these, avoiding Chunked.md and Joined.md at Kevin's request. Nearly all of my feedback is in the form of suggestions, so you can apply them more easily.

Feel free to reach out to me if you have questions, or if you'd like me to take another look.

Copy link
Contributor

@invalidname invalidname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a fairly light editorial pass over these, avoiding Chunked.md and Joined.md at Kevin's request. Nearly all of my feedback is in the form of suggestions, so you can apply them more easily.

Feel free to reach out to me if you have questions, or if you'd like me to take another look.

@invalidname
Copy link
Contributor

Sorry for the duplicate comments; GitHub was having trouble submitting the form and reloading the page.

@@ -59,6 +84,26 @@ Include `"AsyncAlgorithms"` as a dependency for your executable target:

Finally, add `import AsyncAlgorithms` to your source code.

## Getting Started
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parkera this is the conclusion I came to with the help of @tomerd and @neonichu

@phausler phausler merged commit 4d4022e into main Mar 18, 2022
@phausler phausler deleted the pr/guides branch March 18, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants