Skip to content

First pass at some documentation for combineLatest #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2022
Merged

First pass at some documentation for combineLatest #94

merged 2 commits into from
Mar 18, 2022

Conversation

phausler
Copy link
Member

Very rough first coverage of combineLatest and associated types.

invalidname
invalidname approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@invalidname invalidname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of your source docs are hard-wrapped, but this is soft-wrapped. Consider hard line break on line 30 for consistency.

@phausler phausler force-pushed the pr/combine_latest_inline_docs branch from a5c34b2 to 099f42d Compare March 18, 2022 17:21
@phausler phausler merged commit b11a32f into main Mar 18, 2022
@phausler phausler deleted the pr/combine_latest_inline_docs branch March 18, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invalidname invalidname invalidname approved these changes

@parkera parkera Awaiting requested review from parkera

@jmschonfeld jmschonfeld Awaiting requested review from jmschonfeld

@kperryua kperryua Awaiting requested review from kperryua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phausler @invalidname