Light edit of recent doc comments (rdar://90176127) #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invalidname
commented
Mar 21, 2022
| @@ -10,7 +10,7 @@ | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| /// Creates an asynchronous sequence that concurrently awaits values from two `AsyncSequence` types | |||
| /// by emitting a tuple of the values. | |||
| /// and emits a tuple of the values. | |||
There was a problem hiding this comment.
Revert this (and others like this) if I've changed meaning, but it didn't make sense to me to say the sequence "concurrently awaits… by emitting". I think it awaits the other sequences, and then emits tuples as the source sequences produce values.
parkera
approved these changes
Mar 21, 2022
| @@ -10,7 +10,7 @@ | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| /// Creates an asynchronous sequence that concurrently awaits values from two `AsyncSequence` types | |||
| /// by emitting a tuple of the values. | |||
| /// and emits a tuple of the values. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light edit of new docs from #97, plus anything else that stands out.
Mostly just spelling. Not a full-on rewrite to DevPubs style, so the passive voice and future tense can stay for now.