Replace SpanStatus.CanonicalCode with OTel status code #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Dec 14, 2020
| public struct SpanStatus { | ||
| public let canonicalCode: CanonicalCode | ||
| public let code: Code |
There was a problem hiding this comment.
Should it be possible to set one with undefined status code?
There was a problem hiding this comment.
Should it be possible to set one with undefined status code?
@ktoso
Good question ... I don't think so, as unset basically means you haven't altered the status. The only use-case would be to set it at first, then reset it afterwards. But I don't think that's a real concern.
ktoso
reviewed
Dec 14, 2020
ktoso
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29