Skip to content

The README file in this repo has a bad link - [404:NotFound] #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

MrCull
Copy link
Contributor

@MrCull MrCull commented Dec 19, 2020

The markup version of the readme that is displayed for the main page in this repo contains the following bad link:

"Context argument naming/positioning" & “Context propagation”
Status code [404:NotFound] - Link: https://github.com/apple/swift-distributed-tracing/tree/wip-readme-release#context-propagation-by-explicit-loggingcontext-passing

They should just be: #context-propagation-by-explicit-loggingcontext-passing

Extra

This bad link was found by a tool I recently created as part of an new experimental hobby project: https://github.com/MrCull/GitHub-Repo-ReadMe-Dead-Link-Finder

Re-check this Repo using the tool’s website: http://githubreadmechecker.com/Home/Search?SingleRepoUri=https%3a%2f%2fi.8713187.xyz%2fapple%2fswift-distributed-tracing

If this has been helpful, or if you have any feedback on the tool itself, then please feel free to share your thoughts by adding a comment here, or adding to a “Discussion” in the tool’s Repo.

The markup version of the readme that is displayed for the main page in this repo contains the following bad link:

"Context argument naming/positioning" & “Context propagation”
Status code [404:NotFound] - Link: https://github.com/apple/swift-distributed-tracing/tree/wip-readme-release#context-propagation-by-explicit-loggingcontext-passing


I think it should just be: #context-propagation-by-explicit-loggingcontext-passing

**Extra**

This bad link was found by a tool I recently created as part of an new experimental hobby project: https://github.com/MrCull/GitHub-Repo-ReadMe-Dead-Link-Finder

Re-check this Repo using the tool’s website: Re-check this Repo via: http://githubreadmechecker.com/Home/Search?SingleRepoUri=https%3a%2f%2fi.8713187.xyz%2fapple%2fswift-distributed-tracing

If this has been helpful, or if you have any feedback on the tool itself, then please feel free to share your thoughts by adding a comment here, or adding to a “Discussion” in the tool’s Repo.
@swift-server-bot
Copy link

Can one of the admins verify this patch?

4 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@ktoso
Copy link
Member

ktoso commented Dec 20, 2020

Thanks :-) hah yeah the never ending battle to fix dead links... definitely toolable, thanks I'll have a look at your project too :)

@ktoso
Copy link
Member

ktoso commented Dec 20, 2020

@swift-server-bot test this please

@ktoso ktoso merged commit b50cfc1 into apple:main Dec 21, 2020
@ktoso ktoso added this to the 0.1.3 milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants