Fix MainThreadCheckerRuntime.cpp to recognize properties from functions. (#681)

* Fix MainThreadCheckerRuntime.cpp to recognize properties from functions.

<rdar://problem/36557167>

* Move the fix to <swiftlang/swift#17150> and update MainThreadCheckerRuntime.cpp to stop using .loadAllMembers().

Author: kubamracek

packages/Python/lldbsuite/test/functionalities/mtc/swift-property/TestMTCSwiftProperty.py

@@ -17,7 +17,6 @@ class MTCSwiftPropertyTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipUnlessDarwin
-    @expectedFailureAll(bugnumber="rdar://problem/36557167")
     def test(self):
         self.mtc_dylib_path = findMainThreadCheckerDylib()
         if self.mtc_dylib_path == "":

source/Plugins/InstrumentationRuntime/MainThreadChecker/MainThreadCheckerRuntime.cpp

@@ -118,20 +118,9 @@ static std::string TranslateObjCNameToSwiftName(std::string className,
 
       // If the decl is actually an accessor, use the property name instead.
       swift::AbstractFunctionDecl *decl = funcs.front();
-      if (auto func = llvm::dyn_cast<swift::FuncDecl>(decl)) {
-        swift::DeclContext *funcCtx = func->getParent();
-        // We need to loadAllMembers(), otherwise 'isAccessor' returns false.
-        if (auto extension = llvm::dyn_cast<swift::ExtensionDecl>(funcCtx)) {
-          extension->loadAllMembers();
-        } else if (auto nominal =
-                       llvm::dyn_cast<swift::NominalTypeDecl>(funcCtx)) {
-          nominal->loadAllMembers();
-        }
-
-        if (auto accessor = llvm::dyn_cast<swift::AccessorDecl>(func)) {
-          result = accessor->getStorage()->getFullName();
-          return;
-        }
+      if (auto accessor = llvm::dyn_cast<swift::AccessorDecl>(decl)) {
+        result = accessor->getStorage()->getFullName();
+        return;
       }
 
       result = decl->getFullName();