Skip to content

When loading Obj-C methods via a selector and the method is an accessor, import the property as well. #17150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2018
Merged

When loading Obj-C methods via a selector and the method is an accessor, import the property as well. #17150

merged 1 commit into from
Jun 14, 2018

Conversation

kubamracek
Copy link
Contributor

When loading Obj-C methods via a selector and the method is an accessor, import the property as well. This fixes a failing test in LLDB, apple/swift-lldb#681.

@kubamracek kubamracek requested a review from jrose-apple June 12, 2018 20:55
@kubamracek
Copy link
Contributor Author

@swift-ci please test

kubamracek added a commit to kubamracek/swift-lldb that referenced this pull request Jun 12, 2018
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e88a7b0

@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an LLDB-side test for this, and there's not a good way to keep Swift from loading all the members before we get to any of its uses of ClassDecl::lookupDirect, so not having a test here is acceptable.

@kubamracek kubamracek merged commit 6c33cfa into swiftlang:master Jun 14, 2018
kubamracek added a commit that referenced this pull request Jun 14, 2018
kubamracek added a commit to apple/swift-lldb that referenced this pull request Jun 14, 2018
…ns. (#681)

* Fix MainThreadCheckerRuntime.cpp to recognize properties from functions.

<rdar://problem/36557167>

* Move the fix to <swiftlang/swift#17150> and update MainThreadCheckerRuntime.cpp to stop using .loadAllMembers().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants