This repository was archived by the owner on Mar 28, 2020. It is now read-only.
Relax DIE verification #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relocatable content may have overlapping ranges until the sections are finalized. This reduces the amount of verification that is done on an object file so that invalid errors are not raised. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@345441 91177308-0d34-0410-b5e6-96231b3b80d8
Ensure that the test builds for x86_64 as it is an assembly test. This should repair the buildbots. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@345444 91177308-0d34-0410-b5e6-96231b3b80d8
|
Note that this is a cherry-pick from usptream (I fixed this upstream and am trying to pull this into the swift side). |
|
When cherry-picking, could you use |
|
@adrian-prantl - sure will do! |
|
This seems to be breaking the Linux CI bots: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/6373/ |
|
@adrian-prantl - I had put up #121 to address the issue. The check was overly strict and I had missed the local change for relaxing it when I committed it. Sorry about that. Its already fixed upstream, it was a matter of pulling the fix back down here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the DWARF verifier for object files. In particular, this is important for ELF where COMDATs are created by means of function sections. Each section is independent and the
DW_AT_low_pcis a section relative address. The linker will coalesce the sections into the text segment and then update the debug info. The current approach of verifying the contents of DW_AT_ranges of the CU does not work as a result as the overlapping address is totally valid. The bug was uncovered while trying to fix the IRGen for swift on ELF and COFF targets. Without this change, in order to fix a size regression and a complete failure for building code for Windows targets, we would need to disable tests that verify the generated debug information on object files which would open the door for introducing debug information QoI regressions.CC: @adrian-prantl @JDevlieghere @bob-wilson @tkremenek