Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

Change llvm call once check for building Swift for PowerPC(ppc64le) #129

Closed
wants to merge 1 commit into from
Closed

Change llvm call once check for building Swift for PowerPC(ppc64le) #129

wants to merge 1 commit into from

Conversation

sarveshtamba
Copy link

Change llvm call once check for building Swift for PowerPC(ppc64le). These changes are required to resolve the call_once related errors seen while building the Swift toolchain on PowerPC64LE.

@sarveshtamba
Copy link
Author

This code change needs to go in along with following PRs:
swiftlang/swift#21038
swiftlang/swift-package-manager#1906

@bob-wilson
Copy link
Contributor

Can you get this into the upstream LLVM sources first? This change does not seem like it is specific to Swift.

@sarveshtamba
Copy link
Author

Bug 39912 has been successfully created.
Also I have posted this patch on LLVM's Phabricator suggestion. Following is the link for patch review:-
https://reviews.llvm.org/D55503
Please let me know if anything else is required.

@bob-wilson
Copy link
Contributor

Can you change this PR to be a cherry-pick of r348970 (304fa37)?

@sarveshtamba
Copy link
Author

Hi Bob, please see my comments in https://reviews.llvm.org/D55503

@bob-wilson
Copy link
Contributor

Yes, I saw that. I agree that we'll need to figure out the right solution on trunk before cherry-picking anything here.

@compnerd
Copy link
Collaborator

I'm going to close this PR. The necessary changes have been made in LLVM upstream. If they aren't in the 5.1 branch, we can pull them into the 5.1 branch as backports.

@compnerd compnerd closed this Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants