[upstream-with-swift] Add workaround for MSVC bug #43
Conversation
|
Again, can we get this into real upstream LLVM instead? |
|
Oh, so that's what you meant by upstream :( |
|
For upstream, do you think we should remove the #ifdef and just change from |
|
Ah, sorry for not being clear! I'm not sure how I feel about that. |
No problem, there are two upstreams :D I've opened https://reviews.llvm.org/D29181 for discussion on this - first real submission to LLVM so I hope I've correctly done it :) |
|
Looks like no one has looked at https://reviews.llvm.org/D29181, have I correctly published it? |
|
That's correct enough. I'll poke the owner of TrailingObjects to hopefully get some movement. |
|
Thanks Jordan, appreciate it! |
See swiftlang/swift#3759 (comment) The problem is that MSVC doesn't recognise the following syntax, reporting multiple errors [here](https://github.com/apple/swift/blob/master/include/swift/AST/Expr.h#L661): ``` size_t numTrailingObjects( typename TrailingObjects::template OverloadToken<SourceLoc>) const { return asDerived().hasArgumentLabelLocs() ? asDerived().getNumArguments() : 0; } ``` For some reason, MSVC ignores the fact that we gave friend access to `llvm::TrailingObjects` [here](). Note that the Swift source code also has to be modified, as this is not enough. This is the new source code, that fully compiles after this change! ``` // Work around MSVC bug: can't infer llvm::trailing_objects_internal, even though we granted friend access to it size_t numTrailingObjects( llvm::trailing_objects_internal::TrailingObjectsBase::OverloadToken<Identifier>) const { typename TrailingObjects::template OverloadToken<Identifier>) const { return asDerived().getNumArguments(); } ```
|
Closed this - I'll also handle updating swift, when I get the time |
See swiftlang/swift#3759 (comment)
The problem is that MSVC doesn't recognise the following syntax, reporting multiple errors here:
For some reason, MSVC ignores the fact that we gave friend access to
llvm::TrailingObjectshere.Note that the Swift source code also has to be modified, as this is not enough. This is the new source code, that fully compiles after this change!