Bidirectional stream events #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
reviewed
Jul 4, 2024
Examples/bidirectional-event-streams-client-example/Package.swift
Outdated
Show resolved
Hide resolved
Examples/bidirectional-event-streams-server-example/Package.swift
Outdated
Show resolved
Hide resolved
...server-example/Sources/BidirectionalEventStreamsServer/BidirectionalEventStreamsServer.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Honza Dvorsky <[email protected]>
Co-authored-by: Honza Dvorsky <[email protected]>
|
@swift-server-bot test this please |
|
@akbashev Please run |
Ah, while trying to figure out about streams and URLSession, completely forgot about swift-format. Just run and pushed fixes. |
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working with my swift distributed actors showcase one of the points for me was to try openapi. As this is a chat client showcase, took me some time to realise that you can do bidirectional streaming. Think this is quite an important feature and not very discoverable, so to fill this gap—created two simple examples. Things to consider:
event-streams-_-exampleheartbeatmessages to keep/close connections, but think this should be done by whoever implements the clients.Modifications
Working examples showing bidirectional streaming both for server and client.
Test Plan
I've tested myself, it's working, don't think examples are covered with tests.