Converter SPI methods for required fields should return non-optional types #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation `getRequiredRequestBodyAsText` currently returns `C?` instead of `C`. As the value should be required an optional in the return is causing issues. The errors are `Cannot convert value of type 'C?' to specified type` and `Cannot infer contextual base in reference to member 'text'` ### Modifications Change the return type of `getRequiredRequestBodyAsText` ### Result Code using a required requestBody now compiles without errors.
|
Thanks for the fix, this was an oversight on my part. |
czechboy0
approved these changes
Jun 16, 2023
simonjbeaumont
changed the title
getRequiredRequestBodyAsText
|
@swift-server-bot test this please |
|
@sikevux this is great, thank you. Is it possible to add a test case for this? Specifically something that uses the code that previously world not compile? |
|
Agreed, we have tests already, but adding one that does something like
|
czechboy0
requested changes
Jun 17, 2023
|
Ugh, I took a quick look and we have the same issue in a few more places: Can you please fix those too? 🙏 |
### Modifications All `test_get*` tests for the converters now explicitly set the expected type. Fix the original bug for the following functions as well: * `getRequiredHeaderFieldAsText<T: _StringConvertible>` * `getRequiredHeaderFieldAsText` ### Results All tests pass without issue, after applying the fix ### Test plan Made the changes to the unit tests. Observed code not compiling anymore. Applied fixes. Tests now compile and pass.
Yeah. Modified all the |
simonjbeaumont
approved these changes
Jun 18, 2023
simonjbeaumont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getRequiredRequestBodyAsTextcurrently returnsC?instead ofC. As the value should be required an optional in the return is causing issues.The errors are
Cannot convert value of type 'C?' to specified typeandCannot infer contextual base in reference to member 'text'Modifications
Change the return type of
getRequiredRequestBodyAsTextResult
Code using a required requestBody now compiles without errors.