Update uri decoder for non encoded comma strings

[bfrearson]

Motivation

Makes decoding of non-percent encoded strings containing commas more permissive as per discussion in 278. This is not strictly necessary to adhere to the Openapi spec, but encompasses header values that are not percent encoded.

Modifications

Update the simple unexploded decoder to return a single string of comma separated values.

Result

Simple, unexploded nodes containing commas should be decoded correctly. e.g. foo, bar should be a single string, rather than an array.

Test Plan

Add tests for non percent encoded comma separated strings and percent encoded strings for additional coverage.

[czechboy0]

Looks great!

[czechboy0]

@swift-server-bot test this please

[czechboy0]

@bfrearson Please run ./scripts/soundness.sh and reformat the code, otherwise lgtm!

[bfrearson]

Hopefully all ready to go now!

[czechboy0]

@swift-server-bot add to allowlist

[czechboy0]

@bfrearson the soundness check is still failing, can you check the CI output why?

[bfrearson]

Looks to be an issue with swift-format:

** ✅ Found no files with missing license header.
** Running /code/scripts/run-swift-format.sh...
Tests/OpenAPIRuntimeTests/Conversion/Test_Converter+Client.swift:15:17: warning: [Spacing] remove 1 space
Tests/OpenAPIRuntimeTests/Conversion/Test_Converter+Common.swift:15:17: warning: [Spacing] remove 1 space
Tests/OpenAPIRuntimeTests/Interface/Test_UniversalServer.swift:15:17: warning: [Spacing] remove 1 space
Tests/OpenAPIRuntimeTests/Deprecated/Test_Deprecated.swift:15:17: warning: [Spacing] remove 1 space
Tests/OpenAPIRuntimeTests/Conversion/Test_Converter+Server.swift:15:17: warning: [Spacing] remove 1 space
Tests/OpenAPIRuntimeTests/URICoder/Test_URICodingRoundtrip.swift:15:17: warning: [Spacing] remove 1 space
** ERROR: ❌ Running swift-format produced errors.

  To fix, run the following command:

    % swift-format format --parallel --recursive --in-place Sources Tests
  
** ERROR: ❌ 1 soundness check(s) failed.
1
Build step 'Execute shell' marked build as failure
$ ssh-agent -k

I've run the suggested command locally and there's no changes though. Will take a close look at it tomorrow

[czechboy0]

Might be the version of swift-format? We clone it from main in CI I believe.

[czechboy0]

Actually likely the opposite, we clone the 508.0.0 tag, so you might be using a newer one: https://github.com/apple/swift-openapi-generator/blob/main/docker/Dockerfile

[bfrearson]

yep that was it!