[PlaygroundLogger] Use prefix and suffix when getting the first and last n children for structured log entries.
#26
Conversation
|
@swift-ci Please test |
| } | ||
|
|
||
| XCTAssertEqual(name, "set") | ||
| XCTAssertEqual(totalChildrenCount, 1000) |
There was a problem hiding this comment.
How do we expect 1000 and 101 here. (and 81st item being a gap)
I searched for nilIUO and the only spot it showed up wasn't very clarifying.
There was a problem hiding this comment.
We expect 1000 here because we create a set with 1000 elements above, and that's what we log. (I'm not sure where nilIUO is coming into play in this test because it's the variable for the previous test; set is what's being logged here.)
101 is a bit of a magic number because it's what the default logging policy would create. I'll add a comment to explain why I got that.
| XCTAssertEqual(children.count, 101) | ||
|
|
||
| for (index, childEntry) in children.enumerated() { | ||
| if index == 80 { |
There was a problem hiding this comment.
Did you consider switching over the index and the entry instead of these guards and ifs?
There was a problem hiding this comment.
I did, but since there was only one case to handle specially (index == 80), it felt like it made more sense to just do an if/else. (And it's easier for me to reason about childEntry and the assertions I'm making about it by using a guard to unwrap it instead of trying to unwrap it in a switch.
Offsetting indices only works for collections which implement `BidirectionalCollection`, while `suffix(_:)` is available for all collections. This prevent crashes when e.g. generating a `LogEntry` for instances of `Set`. This addresses <rdar://problem/39791397>.
Offsetting indices only works for collections which implement
BidirectionalCollection, whilesuffix(_:)is available for all collections.This prevent crashes when e.g. generating a
LogEntryfor instances ofSet.This addresses rdar://problem/39791397.