Migrated swift-xcode-playground-support to Swift 4.2 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for <rdar://problem/45676453>.
…S, iOS, and tvOS, and fixed the build for tests. PlaygroundSupport and XCPlayground each had a lot of duplication in their test suites, when all that was different was UIView vs. NSView. This makes each test suite use a single file for the live view-related tests, and also renames the test files to be more functionality-based. This is in preparation to migrate the PlaygroundSupport project to Swift 4.2.
…tests to Swift 4.2. This is for <rdar://problem/45676453>.
… to Swift 4.2. This is for <rdar://problem/45676453>.
…work to Swift 4.2. This is for <rdar://problem/45676453>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accomplished using the Swift migrator in Xcode 10.1, and all of these targets now build with the latest-stable Swift language version (except the legacy PlaygroundLogger framework, which I'm not touching as it should likely be removed rather than updated at this point). This update was tested locally both by using the master snapshot xctoolchain from Swift.org from October 24th, as well as by building everything locally together.
This PR includes some minor reorganization changes to PlaygroundSupport and XCPlayground's tests to minimize code duplication.
This addresses rdar://problem/45676453.