Skip to content

[PlaygroundLogger] Added support for an environment variable which co… #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cwakamo
Copy link
Member

@cwakamo cwakamo commented Mar 3, 2021

…ntrols the maximum depth of logging.

Logging previously unconditionally used a maximum depth of 2 when using one of the regular entry points (because logging would use the default policy).
This commit allows clients to set LOGGER_DEPTH in the environment when launching the process performing logging; if this is set to a valid integer, it will override the default depth of 2.

This addresses rdar://problem/67252287.

@cwakamo cwakamo requested a review from jonathanpenn March 3, 2021 02:57
…ntrols the maximum depth of logging.

Logging previously unconditionally used a maximum depth of 2 when using one of the regular entry points (because logging would use the default policy).
This commit allows clients to set `LOGGER_DEPTH` in the environment when launching the process performing logging; if this is set to a valid integer, it will override the default depth of 2.

This addresses <rdar://problem/67252287>.
@cwakamo cwakamo force-pushed the PlaygroundLogger-override-maximum-depth-env-var branch from dafb12b to 469b06e Compare March 3, 2021 02:58
@cwakamo
Copy link
Member Author

cwakamo commented Mar 3, 2021

This repo doesn't have Swift CI support, but I've tested this locally using the same Xcode tools that are used in Swift CI.

@cwakamo cwakamo merged commit a6d03a5 into apple:main Mar 3, 2021
@cwakamo cwakamo deleted the PlaygroundLogger-override-maximum-depth-env-var branch March 3, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants