[PlaygroundSupport] Removed a couple of vestigial shell script build … #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phases for copying swiftdoc files. These were added before Xcode's build system supported copying swiftdoc files on its own. They've been harmless for the last several years, but because they hard-coded `x86_64`, it means they don't work when building PlaygroundSupport.framework (or the legacy XCPlayground.framework) for `arm64` only. As a result, this commit removes these vestigial build phases; Xcode's built-in support for swiftdoc files is better than these ever were. This addresses <rdar://problem/75513867>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…phases for copying swiftdoc files.
These were added before Xcode's build system supported copying swiftdoc files on its own.
They've been harmless for the last several years, but because they hard-coded
x86_64, it means they don't work when building PlaygroundSupport.framework (or the legacy XCPlayground.framework) forarm64only.As a result, this commit removes these vestigial build phases; Xcode's built-in support for swiftdoc files is better than these ever were.
This addresses rdar://problem/75513867.