Skip to content

Support Ironpython3.4 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 1, 2023
Merged

Support Ironpython3.4 #136

merged 19 commits into from
Jan 1, 2023

Conversation

chuongmep
Copy link
Contributor

@chuongmep chuongmep commented Dec 16, 2022 •
edited
Loading

Purpose

This is an pull request support for Ironpython 3.4 release, we had wait along time to can do that.

Description

Revit_ZnoohL6tsv

Declarations

Check these if you believe they are true

  • This PR fix bug
  • This PR for new feature
  • The codebase is in a better state after this PR
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@daren-thomas @eirannejad

FYIs

@jeremytammik

CyrilWaechter and others added 10 commits September 4, 2022 17:28
@CyrilWaechter
Fix set CollectorExt.m_app error
53651f6 
Assigning m_app is apparently not required anymore in last RevitLookup versions and not even possible.

Error:
"""python
Traceback (most recent call last):
  File "<string>", line 83, in <module>
  File "<string>", line 63, in __init__
TypeError: can't set attributes of built-in/extension type 'CollectorExt'
"""
@daren-thomas
Merge pull request architecture-building-systems#128 from CyrilWaecht…
b9e086c 
…er/patch-1

Fix set CollectorExt.m_app error
@chuongmep
update version
38dcbb4
@chuongmep
Merge branch 'master' into develop
81d0235
@daren-thomas
Merge pull request architecture-building-systems#132 from chuongmep/f…
eecc688 
…ixcicd

update version
@chuongmep
support ironpython3.4
556059b
@chuongmep
Merge branch 'dev' into ironpython3
65a57b9
@chuongmep
Revert "Merge branch 'dev' into ironpython3"
39f230b 
This reverts commit 65a57b9, reversing
changes made to 556059b.
@chuongmep
Merge branch 'develop' into ironpython3
b7f35da
@chuongmep
fix revitlookup
a0e45df
@chuongmep chuongmep changed the base branch from develop to master December 16, 2022 06:41
@chuongmep chuongmep marked this pull request as draft December 16, 2022 07:04
@chuongmep chuongmep changed the base branch from master to develop December 16, 2022 07:09
@chuongmep chuongmep closed this Dec 16, 2022
@chuongmep chuongmep reopened this Dec 16, 2022
@chuongmep chuongmep marked this pull request as ready for review December 16, 2022 08:14
@chuongmep chuongmep changed the base branch from develop to master December 16, 2022 08:14
@chuongmep chuongmep changed the base branch from master to develop December 17, 2022 11:37
@chuongmep chuongmep marked this pull request as draft December 17, 2022 11:43
@chuongmep chuongmep marked this pull request as ready for review December 19, 2022 01:42
daren-thomas
daren-thomas requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@daren-thomas daren-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Exciting!

One minor point: This is a breaking, backwards incompatible change. Python3 is for all intents and purposes a new language and anyone using RPS will have to update all their scripts. We should probably think hard about how to communicate this.

Any ideas? @eirannejad? @jeremytammik?

@jeremytammik
Copy link

backwards incompatible change, and how to communicate this

Maybe the new version can require a shebang header comment. Then it can assume that an old script lacking the comment or specifying a prior version of Python is for Python 2 or previous, try to convert it using 2to3 and explain the problem if that fails.

Re. communication: I can post this on The Building Coder blog and in the Revit API discussion group. @eirannejad and others have lots of twitter followers, so we can try to spread the word there and on linkedin as well. Would that suffice?

@chuongmep
Copy link
Contributor Author

I recommend some document user need read after merge this commit to develop and release in master branch :

@daren-thomas
Copy link
Member

Hmm... the README.md file should probably also be updated (in this PR) to reflect the changes and @chuongmep 's links for further reading also integrated in that updated text.

Since I won't be using this ever, I don't really have a lot of skin in the game. If the three of you are in agreement, I'm fine to merge.

@chuongmep
Copy link
Contributor Author

Hi @daren-thomas , updated to help people can follow with IronPython 3 😉

@daren-thomas
Copy link
Member

@chuongmep thank you very much!

@daren-thomas daren-thomas merged commit ad777c2 into architecture-building-systems:develop Jan 1, 2023
@chuongmep
Copy link
Contributor Author

@daren-thomas, may be we need merge to master branch from develop to GitHub bot can publish a new version.

@daren-thomas
Copy link
Member

sure. can you walk me through the process please?

@chuongmep
Copy link
Contributor Author

@daren-thomas I have create another pull request to do that, just need accept this :
#137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daren-thomas daren-thomas daren-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chuongmep @jeremytammik @daren-thomas @CyrilWaechter