Skip to content

Minor: TimeService debug and formatting #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Feb 3, 2022

Changes:

  • print timezone info only if DEBUG_VERBOSE is enabled
  • add braces to a single statement "if" to improve readability

@codecov-commenter
Copy link

Codecov Report

Merging #302 (b6950ad) into master (b0b75cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          27       27           
  Lines        1113     1113           
=======================================
  Hits         1056     1056           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b75cd...b6950ad. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Memory usage change @ b6950ad

Board flash % RAM for global variables %
arduino:mbed:envie_m4 💚 -160 - 0 -0.02 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 💚 -168 - 0 -0.02 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 💚 -160 - 0 -0.06 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 💚 -160 - 0 -0.06 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 💚 -160 - 0 -0.06 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -160 - 0 -0.06 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 💚 -160 - 0 -0.06 - 0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 💚 -176 - -172 -0.01 - -0.01 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 💚 -196 - -176 -0.02 - -0.02 💚 -80 - -76 -0.1 - -0.09
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:mbed:envie_m4 -160 -0.02 0 0.0 -160 -0.02 0 0.0 -160 -0.02 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 -168 -0.02 0 0.0 -168 -0.02 0 0.0 -160 -0.02 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 -160 -0.06 0 0.0 -160 -0.06 0 0.0 -160 -0.06 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 -160 -0.06 0 0.0 -160 -0.06 0 0.0 -160 -0.06 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 -160 -0.06 0 0.0 -160 -0.06 0 0.0 -160 -0.06 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 -160 -0.06 0 0.0 -160 -0.06 0 0.0 -160 -0.06 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot -160 -0.06 0 0.0 -160 -0.06 0 0.0 -160 -0.06 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 -176 -0.01 0 0.0 -176 -0.01 0 0.0 -172 -0.01 0 0.0
esp8266:esp8266:huzzah -180 -0.02 -76 -0.09 -176 -0.02 -80 -0.1 -196 -0.02 -76 -0.09
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,-160,-0.02,0,0.0,-160,-0.02,0,0.0,-160,-0.02,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,-168,-0.02,0,0.0,-168,-0.02,0,0.0,-160,-0.02,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,-160,-0.06,0,0.0,-160,-0.06,0,0.0,-160,-0.06,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,-160,-0.06,0,0.0,-160,-0.06,0,0.0,-160,-0.06,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,-160,-0.06,0,0.0,-160,-0.06,0,0.0,-160,-0.06,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,-160,-0.06,0,0.0,-160,-0.06,0,0.0,-160,-0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,-160,-0.06,0,0.0,-160,-0.06,0,0.0,-160,-0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,-176,-0.01,0,0.0,-176,-0.01,0,0.0,-172,-0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,-180,-0.02,-76,-0.09,-176,-0.02,-80,-0.1,-196,-0.02,-76,-0.09,,,,,,,,

@pennam pennam added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 9, 2022
@pennam pennam self-assigned this May 9, 2022
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pennam
Copy link
Collaborator Author

pennam commented Feb 16, 2023

superseded by #353

@pennam pennam closed this Feb 16, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 16, 2023
@pennam pennam deleted the remove_tz_log branch May 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants