Skip to content

bin2ota Fix: Add missing colon #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

bin2ota Fix: Add missing colon #352

merged 1 commit into from
Feb 23, 2023

Conversation

Jorgetrujilloroman
Copy link
Contributor

@Jorgetrujilloroman Jorgetrujilloroman commented Feb 10, 2023

Now it looks like:

elif board == "NICLA_VISION":

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Feb 10, 2023
@per1234
Copy link
Contributor

per1234 commented Feb 10, 2023

Thanks for your pull request @Jorgetrujilloroman!

I have another problem: When I try to execute the bin2ota program, it show me an error:

"ModuleNotFounfError: No module named 'crccheck'

Since it is not related to the code defect addressed here, please open a dedicated issue about the lack of documentation/infrastructure for managing the package dependency of this script.

@Jorgetrujilloroman
Copy link
Contributor Author

Done, could fix the Module error by installing the crccheck module after install python pip on my ubuntu. Thank you very much.

@pennam pennam changed the title Fix missing : on line 29 next no "NICLA VISION" bin2ota Fix: Add missing colon Feb 13, 2023
@pennam
Copy link
Collaborator

pennam commented Feb 13, 2023

Hi @Jorgetrujilloroman Thanks for the fix.
Can you please reword the commit description removing non relevant information?

Something like the PR title should be fine.

Thanks

@pennam pennam self-requested a review February 13, 2023 07:47
Copy link
Collaborator

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is good, could you please reword the commit description as requested in the PR conversation?

@per1234 per1234 added the status: changes requested Changes to PR are required before merge label Feb 13, 2023
Adding missing colon on line 29
Copy link
Collaborator

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pennam pennam removed the status: changes requested Changes to PR are required before merge label Feb 15, 2023
@jcarolinares
Copy link

Hey @pennam I don't have rights to merge this PR, could you please do it? :)

@pennam pennam merged commit e49373c into arduino-libraries:master Feb 23, 2023
@Jorgetrujilloroman Jorgetrujilloroman deleted the patch-1 branch February 23, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants