Skip to content

Preferences api introduction #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 25, 2025
Merged

Preferences api introduction #284

merged 8 commits into from
Mar 25, 2025

Conversation

andreagilardoni
Copy link
Contributor

No description provided.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 31, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link

Memory usage change @ 95c0b15

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 🔺 0 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 🔺 0 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/AP_SimpleWebServer
flash		 % examples/AP_SimpleWebServer
RAM for global variables		 % examples/ConnectNoEncryption
flash		 % examples/ConnectNoEncryption
RAM for global variables		 % examples/ConnectWithWEP
flash		 % examples/ConnectWithWEP
RAM for global variables		 % examples/ConnectWithWPA
flash		 % examples/ConnectWithWPA
RAM for global variables		 % examples/ConnectWithWPA2Enterprise
flash		 % examples/ConnectWithWPA2Enterprise
RAM for global variables		 % examples/PreferencesCounter
flash		 % examples/PreferencesCounter
RAM for global variables		 % examples/PreferencesValidation
flash		 % examples/PreferencesValidation
RAM for global variables		 % examples/Prefs2Struct
flash		 % examples/Prefs2Struct
RAM for global variables		 % examples/ScanNetworks
flash		 % examples/ScanNetworks
RAM for global variables		 % examples/ScanNetworksAdvanced
flash		 % examples/ScanNetworksAdvanced
RAM for global variables		 % examples/SimpleWebServerWiFi
flash		 % examples/SimpleWebServerWiFi
RAM for global variables		 % examples/Tools/CheckFirmwareVersion
flash		 % examples/Tools/CheckFirmwareVersion
RAM for global variables		 % examples/Tools/FirmwareUpdater
flash		 % examples/Tools/FirmwareUpdater
RAM for global variables		 % examples/Tools/SerialNINAPassthrough
flash		 % examples/Tools/SerialNINAPassthrough
RAM for global variables		 % examples/WiFiAdvancedChatServer
flash		 % examples/WiFiAdvancedChatServer
RAM for global variables		 % examples/WiFiChatServer
flash		 % examples/WiFiChatServer
RAM for global variables		 % examples/WiFiPing
flash		 % examples/WiFiPing
RAM for global variables		 % examples/WiFiSSLClient
flash		 % examples/WiFiSSLClient
RAM for global variables		 % examples/WiFiStorage
flash		 % examples/WiFiStorage
RAM for global variables		 % examples/WiFiUdpNtpClient
flash		 % examples/WiFiUdpNtpClient
RAM for global variables		 % examples/WiFiUdpSendReceiveString
flash		 % examples/WiFiUdpSendReceiveString
RAM for global variables		 % examples/WiFiWebClient
flash		 % examples/WiFiWebClient
RAM for global variables		 % examples/WiFiWebClientRepeating
flash		 % examples/WiFiWebClientRepeating
RAM for global variables		 % examples/WiFiWebServer
flash		 % examples/WiFiWebServer
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
arduino:samd:mkrvidor4000 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
arduino:samd:mkrwifi1010 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
arduino:samd:nano_33_iot 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
Click for full report CSV 
Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/PreferencesCounter<br>flash,%,examples/PreferencesCounter<br>RAM for global variables,%,examples/PreferencesValidation<br>flash,%,examples/PreferencesValidation<br>RAM for global variables,%,examples/Prefs2Struct<br>flash,%,examples/Prefs2Struct<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiAdvancedChatServer<br>flash,%,examples/WiFiAdvancedChatServer<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0
arduino:samd:mkrvidor4000,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0
arduino:samd:mkrwifi1010,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0
arduino:samd:nano_33_iot,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0

@pennam pennam self-requested a review March 19, 2025 10:42
pennam
pennam requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing fro arduino:megaavr:uno2018. I would also rename Preferences.ccp/.h in WiFiPreferences.cpp/.h

@pennam pennam added the 2.x.x label Mar 19, 2025
@andreagilardoni andreagilardoni requested a review from pennam March 19, 2025 13:21
@github-actions GitHub Actions
Copy link

Memory usage change @ 23a5406

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 🔺 +12 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=on 🔺 +16 - +16 +0.03 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 🔺 +12 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +12 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 +12 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/AP_SimpleWebServer
flash		 % examples/AP_SimpleWebServer
RAM for global variables		 % examples/ConnectNoEncryption
flash		 % examples/ConnectNoEncryption
RAM for global variables		 % examples/ConnectWithWEP
flash		 % examples/ConnectWithWEP
RAM for global variables		 % examples/ConnectWithWPA
flash		 % examples/ConnectWithWPA
RAM for global variables		 % examples/ConnectWithWPA2Enterprise
flash		 % examples/ConnectWithWPA2Enterprise
RAM for global variables		 % examples/PreferencesCounter
flash		 % examples/PreferencesCounter
RAM for global variables		 % examples/PreferencesValidation
flash		 % examples/PreferencesValidation
RAM for global variables		 % examples/Prefs2Struct
flash		 % examples/Prefs2Struct
RAM for global variables		 % examples/ScanNetworks
flash		 % examples/ScanNetworks
RAM for global variables		 % examples/ScanNetworksAdvanced
flash		 % examples/ScanNetworksAdvanced
RAM for global variables		 % examples/SimpleWebServerWiFi
flash		 % examples/SimpleWebServerWiFi
RAM for global variables		 % examples/WiFiAdvancedChatServer
flash		 % examples/WiFiAdvancedChatServer
RAM for global variables		 % examples/WiFiChatServer
flash		 % examples/WiFiChatServer
RAM for global variables		 % examples/WiFiPing
flash		 % examples/WiFiPing
RAM for global variables		 % examples/WiFiSSLClient
flash		 % examples/WiFiSSLClient
RAM for global variables		 % examples/WiFiStorage
flash		 % examples/WiFiStorage
RAM for global variables		 % examples/WiFiUdpNtpClient
flash		 % examples/WiFiUdpNtpClient
RAM for global variables		 % examples/WiFiUdpSendReceiveString
flash		 % examples/WiFiUdpSendReceiveString
RAM for global variables		 % examples/WiFiWebClient
flash		 % examples/WiFiWebClient
RAM for global variables		 % examples/WiFiWebClientRepeating
flash		 % examples/WiFiWebClientRepeating
RAM for global variables		 % examples/WiFiWebServer
flash		 % examples/WiFiWebServer
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
arduino:megaavr:uno2018:mode=on 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 N/A N/A N/A N/A 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0 16 0.03 0 0.0
arduino:samd:mkrvidor4000 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
arduino:samd:mkrwifi1010 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
arduino:samd:nano_33_iot 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0
Click for full report CSV 
Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/PreferencesCounter<br>flash,%,examples/PreferencesCounter<br>RAM for global variables,%,examples/PreferencesValidation<br>flash,%,examples/PreferencesValidation<br>RAM for global variables,%,examples/Prefs2Struct<br>flash,%,examples/Prefs2Struct<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/WiFiAdvancedChatServer<br>flash,%,examples/WiFiAdvancedChatServer<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,,,,,,,,,N/A,N/A,N/A,N/A,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0,16,0.03,0,0.0
arduino:samd:mkrvidor4000,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0
arduino:samd:mkrwifi1010,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0
arduino:samd:nano_33_iot,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0

pennam
pennam requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use an env variable like this https://github.com/arduino-libraries/ArduinoIoTCloud/blob/501271b5a868c178595265d4c83b0777aba8fe28/.github/workflows/compile-examples.yml#L30 instead of repeating all the examples path per board

@github-actions GitHub Actions
Copy link

Memory usage change @ 4ff07e7

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:samd:mkrvidor4000 N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report table
Board examples/PreferencesCounter
flash		 % examples/PreferencesCounter
RAM for global variables		 % examples/PreferencesValidation
flash		 % examples/PreferencesValidation
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A N/A N/A N/A N/A
arduino:samd:mkrvidor4000 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/PreferencesCounter<br>flash,%,examples/PreferencesCounter<br>RAM for global variables,%,examples/PreferencesValidation<br>flash,%,examples/PreferencesValidation<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkrvidor4000,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@andreagilardoni andreagilardoni requested a review from pennam March 19, 2025 13:42
pennam
pennam approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💪 I will give it a spin and then merge it in the 2.x.x branch

@github-actions github-actions bot removed the 2.x.x label Mar 20, 2025
@pennam pennam added the 2.x.x label Mar 25, 2025
@pennam pennam changed the base branch from master to 2.x.x March 25, 2025 12:29
@pennam pennam merged commit 2a19b6f into arduino-libraries:2.x.x Mar 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreagilardoni @pennam @per1234