Bug in SoftwareSerial when using inverse logic #1362

jenscski · 2013-04-12T08:21:24Z

Fix for reported bug #1361

matthijskooijman · 2014-04-15T20:34:57Z

Looking at the code in the ide-1.5.x branch, this pullrequest still seems relevant. The commit looks correct to me.

Only comment I have is that the commit message is terse and doesn't really describe what the problem was or how the fix works. Perhaps that can be fixed (combined with a rebase to drop all the merge commits)?

jenscski · 2014-05-12T08:33:21Z

Hello, a better explanation of the bug can be found here http://forum.arduino.cc/index.php?topic=159726

I have noticed I have added many new merge commits to the pull request, this due to my little knowledge of how pull request works... But I will look into the rebase thing to see if I find out how...

matthijskooijman · 2014-05-12T12:10:07Z

When you merge (or git pull, which does a merge), git creates a merge commit for you, merging your changes with the upstream changes (from the Arduino repo). If you do a git pull --rebase, or git fetch and then git rebase origin/master, it should instead "replay" your commits on top of the latest master, which makes only your commits appear here. Afterwords, you must use git push --force to overwrite the commits here.

jenscski · 2014-05-12T12:21:55Z

I think I have done some major fail when merging, can I delete this pull request and make a new one?

matthijskooijman · 2014-05-12T15:38:14Z

You can, but if you just clean up thinks locally and use git push --force to overwrite the master branch in your repository, this pullrequest will automatically be updated as well. If you want to make a pullrequest for another branch, you'll have to close this one and open a new one, you can't edit the branch for an existing pullreq AFAIK (and you can't delete a pullreq, only close it).

This alters the debounce example code to toggle the LED rather than just use the button state to set the LED state. Fixes #293

… needed for Windows installer

Fixes #953

…header

…tControl example Fixes #1063

…nt with the comment in the header and the tutorial. Fixes #1396

…ew .cat

… of private. This allows better optimization on classes that extends Stream without losing timeout capabilities.

This reverts commit 1866050.

… and hidden files

Conflicts: app/src/processing/app/helpers/FileUtils.java app/test/processing/app/tools/ZipDeflaterTest.java

Changed SS pin to 4 for consistency with other examples

…ng algorithm

This reverts commit 7fcba37.

…sketches After merging #1859, old sketches that uses Robot_Control library must include Wire.h and SPI.h to work properly.

See #1847 and #1117

Decapitalised secondary headings and linked the *Credits* section

See #1853

See #1117

…acter

… editor

Added Mouse.press to Esplora Joystick Mouse example

See #1765

also make ToDo a link

The comments explaining the if..else part were mistaken.

Updated to reflect changes with how the IDE creates new blank sketches.

removed the variable “led” and added some additional descriptive text

jenscski · 2014-05-23T09:34:09Z

I think I totaly wrecked my respository, so can you delete this, and look at this pull request instead?

#2090

Bug in SoftwareSerial when using inverse logic

bb9ba54

ffissore added New and removed New labels Feb 27, 2014

miek and others added 21 commits May 12, 2014 19:30

Fix Debounce example to work as described

e061a04

This alters the debounce example code to toggle the LED rather than just use the button state to set the LED state. Fixes #293

Added support for all variants of Sanguino

2937bce

added driver install utility (dpinst 32- and 64-bit) and Arduino icon…

ecb774c

… needed for Windows installer

small changes to the Debounce example

ae7f92f

Moved refresh client from html meta tag to http header

ea990f6

Fixes #953

WifiWebServer example: Moved the autorefresh feature inside the http …

c6544f6

…header

WebServer example: Added comments

ed9be1e

Support select-paste on Linux (Paul Stoffregen)

ee1eeec

Add "Copy To Clipboard" button for compile errors (Paul Stoffregen)

03201e6

Corrected the return type of the digitalPotWrite in the SPI/DigitalPo…

efe03b1

…tControl example Fixes #1063

changed the pin where to connect the button from 2 to 4 to be complia…

8cccafa

…nt with the comment in the header and the tutorial. Fixes #1396

updated driver description string to "Arduino USB Driver". includes n…

199f216

…ew .cat

Nicer button for 'Copy error to clipboard'

35e1601

Stream "_timeout" field and related methods are now protected instead…

2e28ab2

… of private. This allows better optimization on classes that extends Stream without losing timeout capabilities.

Added c_str() method to String class.

898e163

Added const modifier to String.c_str()

d720d5e

added colored keywords readString and readStringUntil

af725a2

Revert ""Add library" moved into "Import library" menu"

7d8c681

This reverts commit 1866050.

keep included folder name as top level folder name, delete MAC folder…

5a9bc14

… and hidden files

import library also import folder (already expanded libraries)

c7d7a67

Conflicts: app/src/processing/app/helpers/FileUtils.java app/test/processing/app/tools/ZipDeflaterTest.java

"Add library" moved into "Import library" menu

e777bdc

KonradIT and others added 28 commits May 12, 2014 19:32

Rename README.mkdn to README.md

85daa2c

Updated Listfiles SD example

6474abf

Changed SS pin to 4 for consistency with other examples

WiFi Shield examples: added the firmware version check

409554e

If 2 libs have same .h file, use the lib with same dir name

cfe24c7

Fixed issue #1478, #1599, #1709, motors being opposite, updated turni…

fb50563

…ng algorithm

Revert "Changed pins definition in variants from constants to #defines."

abe0cfb

This reverts commit 7fcba37.

Added some friendly messages for Arduino Robot include errors on old …

c467b8a

…sketches After merging #1859, old sketches that uses Robot_Control library must include Wire.h and SPI.h to work properly.

Added license for Arduino.h, binary.h and main.cpp (master branch)

966959d

See #1847 and #1117

Added license for Client, IPAddressm and Server (master branch)

34be368

See #1847 and #1117

Update README.md

ac2a9ea

Decapitalised secondary headings and linked the *Credits* section

Local (user installed) libraries have priority over system libraries

0679694

See #1853

Removed unused code, fixed indentation.

8d2a6a5

Corrected repeated 'less' in checkName's message

e64cfa4

Added copyright license for WiFi shield library

4dce78a

See #1117

Windows: arduino_debug.exe. Backport of ad2ff73

bae0f01

added support for '-' and '.' but both not as the first as first char…

e9b8ff2

…acter

cut the filename at the last '.' not at the first in tab-names of the…

7f506c1

… editor

Esplora: added reading form Tinkerkit inputs

87d6509

Windows: launch4j gets downloaded at build time

3fd2320

Update to Esplora example

5b69564

Added Mouse.press to Esplora Joystick Mouse example

Added compatibity for 1.5 libraries layout on IDE 1.0.x

f399d28

See #1765

Update README.md

bc2ee29

also make ToDo a link

Fixed string constructor overloading bug

5cf12b0

Import WString from 1.5.6

8f4c11a

Fixed example StringStartsWithEndsWith.ino

1c896a4

fix comments on spaceship example

8ddee77

The comments explaining the if..else part were mistaken.

Modified Keyboard Reprogram example

187b5c6

Updated to reflect changes with how the IDE creates new blank sketches.

Updated Blink

7f414a4

removed the variable “led” and added some additional descriptive text

jenscski closed this May 23, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bug in SoftwareSerial when using inverse logic #1362

Bug in SoftwareSerial when using inverse logic #1362

Uh oh!

jenscski commented Apr 12, 2013

Uh oh!

matthijskooijman commented Apr 15, 2014

Uh oh!

jenscski commented May 12, 2014

Uh oh!

matthijskooijman commented May 12, 2014

Uh oh!

jenscski commented May 12, 2014

Uh oh!

matthijskooijman commented May 12, 2014

Uh oh!

jenscski commented May 23, 2014

Uh oh!

Uh oh!

Uh oh!

Bug in SoftwareSerial when using inverse logic #1362

Bug in SoftwareSerial when using inverse logic #1362

Uh oh!

Conversation

jenscski commented Apr 12, 2013

Uh oh!

matthijskooijman commented Apr 15, 2014

Uh oh!

jenscski commented May 12, 2014

Uh oh!

matthijskooijman commented May 12, 2014

Uh oh!

jenscski commented May 12, 2014

Uh oh!

matthijskooijman commented May 12, 2014

Uh oh!

jenscski commented May 23, 2014

Uh oh!

Uh oh!