Fix loading of sketches with folder and main file mismatched casing #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
scerza/sketch-case-sensitivity
branch
from
f769abb to
7bcd058
Compare
ubidefeo
approved these changes
Feb 9, 2021
silvanocerza
force-pushed
the
scerza/sketch-case-sensitivity
branch
from
7bcd058 to
7abe105
Compare
cmaglie
approved these changes
Feb 9, 2021
silvanocerza
added a commit
that referenced
this pull request
Feb 9, 2021
…1179) * Fix loading of sketches with folder and main file mismatched casing * [skip changelog] Fix legacy tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes an OS X specific bug.
Sketches with mismatched folder and main file casing cause several issues for the IDE on OS X.
Since paths case sensitivity can be enabled or disabled on OS X some example sketches in certain libraries are considered valid even if they don't have the same identical name.
These would be considered valid sketches on OS X even if they're not following the specification:
Sketches with mismatched folder and main file casing are now correctly ignored on OS X.
Nope.
Fixes #1174
I had to fix lots of tests in the legacy package because of this fix.
See how to contribute