debugger: some improvements in configuration handling #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
cli_debug_improvements
branch
from
1463405 to
a36dff0
Compare
umbynos
suggested changes
Oct 12, 2023
Co-authored-by: Umberto Baldi <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2364 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 203 203
Lines 19243 19243
=======================================
Hits 12108 12108
Misses 6075 6075
Partials 1060 1060
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
umbynos
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Added some small fix in how the debugger configuration is handled:
debug.server.openocd.scripts.N.debug.server.openocd.scriptdirective is ignored if is together with thedebug.server.openocd.scripts.N.What is the current behavior?
debug.server.openocd.scripts.Nsequence was truncated at the first non-consecutive item.scriptandscriptswere concatenated in the resulting config.What is the new behavior?
debug.server.openocd.scripts.Nsequence is not truncated even if the items are non-consecutive.sciptandscriptsare mutually-exclusive in the config with priority given toscripts.Does this PR introduce a breaking change, and is titled accordingly?
Other information