Skip to content

11885 - Added note for 3.3V boards (ReadAnalogVoltage) #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pedromsousalima
Copy link
Contributor

What This PR Changes

  • Added note for 3.3V boards

Contribution Guidelines

@pedromsousalima pedromsousalima added fix/update A small fix or update community Bugs and fixes suggested by the community preview labels Aug 1, 2024
@pedromsousalima pedromsousalima self-assigned this Aug 1, 2024
@jacobhylen jacobhylen linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also consider that we have board with different ADC resolutions.
Can we add a comment about this too?

Copy link

github-actions bot commented Aug 1, 2024

Preview Deployment

🚀 Preview this PR: https://66aba2f839bf4109ce18f250--docs-content.netlify.app
📍 Commit SHA: 5b65269

@pedromsousalima
Copy link
Contributor Author

@jacobhylen Good point. Added information on that too! Thank you

Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedromsousalima pedromsousalima merged commit 0f19ecf into main Aug 12, 2024
4 checks passed
@pedromsousalima pedromsousalima deleted the pedromsousalima/builtinexamples_AnalogVoltage_3V3 branch August 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ReadAnalogVoltage?
2 participants