Skip to content

[MKC-1824] Correct errors in Alvik User Manual #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 25, 2024

Conversation

pedromsousalima
Copy link
Contributor

What This PR Changes

  • Fixed typos and added full code

Contribution Guidelines

Added full code snippet
Fixed connection errors
@pedromsousalima pedromsousalima added fix/update A small fix or update preview labels Sep 9, 2024
@pedromsousalima pedromsousalima self-assigned this Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Preview Deployment

🚀 Preview this PR: https://66f3fc49fadf70010453f4bf--docs-content.netlify.app
📍 Commit SHA: 2fb0da8

Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pedromsousalima the linter points out some errors with images not used, and images missing.

Seems like the image at the top is not imported properly.

Screenshot 2024-09-12 at 10 30 41

Otherwise looks good, I do not have the Alvik to test the code, can you give it a run and see if it works?

@pedromsousalima
Copy link
Contributor Author

@karlsoderby Thanks for pointing that out. It is fixed now!

Copy link
Contributor

@g-castronovo g-castronovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some comments

@pedromsousalima pedromsousalima merged commit 62eaa90 into main Sep 25, 2024
4 checks passed
@pedromsousalima pedromsousalima deleted the Pedromsousalima/Alvik/UMFixes branch September 25, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix/update A small fix or update preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants