Skip to content

Add my library URL #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Add my library URL #4271

merged 3 commits into from
Mar 29, 2024

Conversation

Amethyste-PCB
Copy link
Contributor

Add the URL for the main github repository of a library for the IMU sensor LSM6DS3.

Add the URL for the main github repository of a library for the IMU sensor LSM6DS3.
@github-actions github-actions bot added the topic: submission Add library to the list label Mar 27, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/Amethyste-PCB/Amethyste_LSM6DS3

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Amethyste-PCB
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Mar 28, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Amethyste-PCB. Thanks for your interest in contributing to the Arduino Library Manager index.

I see the bot reported a problem with your submission that will block its acceptance:

❌ ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Create a new release or tag in the library repository.
  2. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Mar 28, 2024
@Amethyste-PCB
Copy link
Contributor Author

i added a release for my library, you can continue to check that the library is in accordance with Arduino standards @ArduinoBot .

@github-actions github-actions bot requested a review from per1234 March 28, 2024 19:35
@github-actions github-actions bot added status: maintenance required Infrastructure failure unrelated to request and removed status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list labels Mar 28, 2024

This comment was marked as resolved.

@per1234 per1234 removed their assignment Mar 29, 2024
@per1234
Copy link
Contributor

per1234 commented Mar 29, 2024

@ArduinoBot please check it again.

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot added topic: submission Add library to the list and removed status: maintenance required Infrastructure failure unrelated to request labels Mar 29, 2024
@github-actions github-actions bot removed the request for review from per1234 March 29, 2024 05:32
Copy link
Contributor

A problem was found with your submission https://github.com/Amethyste-PCB/Amethyste_LSM6DS3

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @Amethyste-PCB
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@arduino arduino deleted a comment from github-actions bot Mar 29, 2024
@arduino arduino deleted a comment from github-actions bot Mar 29, 2024
@arduino arduino deleted a comment from github-actions bot Mar 29, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Amethyste-PCB. The problem still remains. If you look at the repository's tags page you can see there is no tag:

https://github.com/Amethyste-PCB/Amethyste_LSM6DS3/tags

If you created the tag in your local clone of the repository, make sure to push the tag to the remote on GitHub.

You can learn how to make a release and tag via the GitHub web interface from this tutorial:

https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository

Once that is done, add a comment here in the pull request thread that mentions @ArduinoBot as you did before.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Mar 29, 2024
@Amethyste-PCB
Copy link
Contributor Author

I apologize for the mistake, i added a tag for my fork of the Arduino library-registry instead of my library repository. It should be good now @ArduinoBot .

@github-actions github-actions bot requested a review from per1234 March 29, 2024 15:48
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Mar 29, 2024
@github-actions github-actions bot removed the request for review from per1234 March 29, 2024 15:49
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Amethyste-PCB/Amethyste_LSM6DS3:

Linting library in Amethyste_LSM6DS3
WARNING: library.properties name value Amethyste_LSM6DS3 is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP010)                                                                                           
WARNING: A commonly misspelled word was found in the library.properties sentence field. Suggested correction: Expose les
         fonctionnalités des captures LSM6DS3.                                                                          
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP033)                                                                                                   
WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in Amethyste_LSM6DS3/examples/AccelBasic

Linter results for project: no errors or warnings

-------------------

Linting sketch in Amethyste_LSM6DS3/examples/AccelGyroTemp

Linter results for project: no errors or warnings

-------------------

Linting sketch in Amethyste_LSM6DS3/examples/FreeFall

Linter results for project: no errors or warnings

-------------------

Linting sketch in Amethyste_LSM6DS3/examples/Tap

Linter results for project: no errors or warnings

-------------------

Linting sketch in Amethyste_LSM6DS3/examples/WristTilt

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit 14951e8 into arduino:main Mar 29, 2024
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Amethyste-PCB/Amethyste_LSM6DS3/

github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants