-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Update repositories.txt #4319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repositories.txt #4319
Conversation
Hi @1ux. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
Arduino Lint has suggestions for possible improvements to https://github.com/1ux/LED_RGB_Control:
|
I have fixed the lint warnings in the BasicColorLedControl library and renamed it to LED_RGB_Control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @1ux.
renamed it to LED_RGB_Control
I see you have changed the value of the name
field of the library.properties
metadata field:
https://github.com/1ux/LED_RGB_Control/blob/main/library.properties#L1
name=LED_RGB_Control
However, Library Manager works exclusively from Git tags, so the indexer system can't recognize the name change until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that it still has the old name value:
https://github.com/1ux/LED_RGB_Control/blob/v1.1/library.properties#L1
name=BasicColorLedControl
So if you want to request a change of the registered library name, you must first make a new release. Once you have done that, comment here to let me know I can proceed with your request..
If you have any questions or concerns, please let me know.
Regards, Per
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there was no response regarding my previous comment about the change to the library name even after some days, I decided to just proceed with the URL update.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done:
2024/04/11 15:12:47 Loaded 6823 libraries from DB
Changing URL of library BasicColorLedControl from https://github.com/1ux/BasicColorLedControl.git to https://github.com/1ux/LED_RGB_Control.git
Success!
No description provided.