Skip to content

Update repositories.txt #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Update repositories.txt #4319

merged 1 commit into from
Apr 11, 2024

Conversation

1ux
Copy link
Contributor

@1ux 1ux commented Apr 6, 2024

No description provided.

@github-actions github-actions bot added the topic: modification Change existing list entry label Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

Hi @1ux.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

github-actions bot commented Apr 6, 2024

Arduino Lint has suggestions for possible improvements to https://github.com/1ux/LED_RGB_Control:

Linting library in LED_RGB_Control
WARNING: library.properties name value BasicColorLedControl is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format    
         (Rule LP010)                                                                                              
WARNING: library.properties version value 1.0 is not compliant with the semver specification.
         See: https://semver.org/                                                            
         (Rule LP021)                                                                        

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in LED_RGB_Control/examples/BasicColorLedControl

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot requested a review from per1234 April 6, 2024 19:52
@1ux
Copy link
Contributor Author

1ux commented Apr 6, 2024

I have fixed the lint warnings in the BasicColorLedControl library and renamed it to LED_RGB_Control.
I have therefore deleted the corresponding old link to the library.

@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Apr 7, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1ux.

renamed it to LED_RGB_Control

I see you have changed the value of the name field of the library.properties metadata field:

https://github.com/1ux/LED_RGB_Control/blob/main/library.properties#L1

name=LED_RGB_Control

However, Library Manager works exclusively from Git tags, so the indexer system can't recognize the name change until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that it still has the old name value:

https://github.com/1ux/LED_RGB_Control/blob/v1.1/library.properties#L1

name=BasicColorLedControl

So if you want to request a change of the registered library name, you must first make a new release. Once you have done that, comment here to let me know I can proceed with your request..

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Apr 7, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there was no response regarding my previous comment about the change to the library name even after some days, I decided to just proceed with the URL update.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added status: pending backend Depends on backend maintenance operations and removed status: waiting for information More information must be provided before work can proceed labels Apr 9, 2024
@MatteoPologruto MatteoPologruto self-assigned this Apr 11, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/04/11 15:12:47 Loaded 6823 libraries from DB
Changing URL of library BasicColorLedControl from https://github.com/1ux/BasicColorLedControl.git to https://github.com/1ux/LED_RGB_Control.git
Success!

@MatteoPologruto MatteoPologruto merged commit 711e5c2 into arduino:main Apr 11, 2024
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants