Skip to content

Update repositories.txt #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update repositories.txt #5589

merged 1 commit into from
Dec 12, 2024

Conversation

Moarbue
Copy link
Contributor

@Moarbue Moarbue commented Dec 12, 2024

No description provided.

Copy link
Contributor

A problem was found with your submission https://github.com/Moarbue/MAX31855-library

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 12, 2024
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Moarbue
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Moarbue
Copy link
Contributor Author

Moarbue commented Dec 12, 2024

yo @ArduinoBot!

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Moarbue/MAX31855-library:

Linting library in MAX31855-library
INFO: No header file found matching library name (MAX31855_Library.h). Best practices are for primary header filename to
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name MAX31855 Library contains spaces. Although supported, best practices is to not use     
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name MAX31855 Library contains "library". This is superfluous.                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: library.properties version value 1.0 is not compliant with the semver specification.
         See: https://semver.org/                                                            
         (Rule LP021)                                                                        
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

@github-actions github-actions bot merged commit 58ce8bb into arduino:main Dec 12, 2024
12 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Moarbue/MAX31855-library/

github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant