Skip to content

Add the private LoRa library #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Interested-In-Spresense
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 15, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/Interested-In-Spresense/E220900t22s_jp

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Interested-In-Spresense
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Interested-In-Spresense
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/Interested-In-Spresense/E220900t22s_jp:

Linting library in E220900t22s_jp
INFO: No header file found matching library name (E220-900T22S_JP__LoRa_library.h). Best practices are for primary      
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value E220-900T22S(JP) LoRa library is longer than the recommended length of 16        
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
ERROR: Prohibited character(s) in library.properties name value: E220-900T22S(JP) LoRa library               
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name E220-900T22S(JP) LoRa library contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name E220-900T22S(JP) LoRa library contains "library". This is superfluous.                   
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Sketch(es) found outside examples and extras folders:                                    
           E220900t22s_jp/example/lora_config                                                     
           E220900t22s_jp/example/lora_recv                                                       
           E220900t22s_jp/example/lora_recv_wor                                                   
           E220900t22s_jp/example/lora_send                                                       
           E220900t22s_jp/example/lora_send_wor                                                   
           E220900t22s_jp/example/lora_trans_recv                                                 
           E220900t22s_jp/example/lora_trans_send                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: Potentially misspelled examples folder name found: E220900t22s_jp/example                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 1 ERRORS, 6 WARNINGS

-------------------

Linting sketch in E220900t22s_jp/example/lora_config

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_recv

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_recv_wor

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_send

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_send_wor

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_trans_recv

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_trans_send

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 6 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Interested-In-Spresense
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Interested-In-Spresense
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/Interested-In-Spresense/E220900t22s_jp:

Linting library in E220900t22s_jp
INFO: No header file found matching library name (E220-900T22S_JP__LoRa_library.h). Best practices are for primary      
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value E220-900T22S(JP) LoRa library is longer than the recommended length of 16        
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
ERROR: Prohibited character(s) in library.properties name value: E220-900T22S(JP) LoRa library               
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name E220-900T22S(JP) LoRa library contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name E220-900T22S(JP) LoRa library contains "library". This is superfluous.                   
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Sketch(es) found outside examples and extras folders:                                    
           E220900t22s_jp/example/lora_config                                                     
           E220900t22s_jp/example/lora_recv                                                       
           E220900t22s_jp/example/lora_recv_wor                                                   
           E220900t22s_jp/example/lora_send                                                       
           E220900t22s_jp/example/lora_send_wor                                                   
           E220900t22s_jp/example/lora_trans_recv                                                 
           E220900t22s_jp/example/lora_trans_send                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: Potentially misspelled examples folder name found: E220900t22s_jp/example                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 1 ERRORS, 6 WARNINGS

-------------------

Linting sketch in E220900t22s_jp/example/lora_config

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_recv

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_recv_wor

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_send

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_send_wor

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_trans_recv

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/example/lora_trans_send

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 6 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Interested-In-Spresense
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Interested-In-Spresense
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Interested-In-Spresense/E220900t22s_jp:

Linting library in E220900t22s_jp
INFO: No header file found matching library name (E220-900T22S_LoRa_library.h). Best practices are for primary header   
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value E220-900T22S LoRa library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
WARNING: library.properties name E220-900T22S LoRa library contains spaces. Although supported, best practices is to not
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name E220-900T22S LoRa library contains "library". This is superfluous.                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

Linting sketch in E220900t22s_jp/examples/lora_config

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/examples/lora_recv

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/examples/lora_recv_wor

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/examples/lora_send

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/examples/lora_send_wor

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/examples/lora_trans_recv

Linter results for project: no errors or warnings

-------------------

Linting sketch in E220900t22s_jp/examples/lora_trans_send

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 4 WARNINGS

@github-actions github-actions bot merged commit ef8ed28 into arduino:main Dec 15, 2024
12 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Interested-In-Spresense/E220900t22s_jp/

github-actions bot pushed a commit that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant