Skip to content

add Adafruit_DACX578 #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025
Merged

add Adafruit_DACX578 #5936

merged 1 commit into from
Feb 15, 2025

Conversation

BlitzCityDIY
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Feb 15, 2025
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/adafruit/Adafruit_DACX578:

Linting library in Adafruit_DACX578
INFO: No header file found matching library name (Adafruit_DAC7578_Library.h). Best practices are for primary header    
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Adafruit DAC7578 Library contains spaces. Although supported, best practices is to not 
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Adafruit DAC7578 Library contains "library". This is superfluous.                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in Adafruit_DACX578/examples/dac7578_sawwave

Linter results for project: no errors or warnings

-------------------

Linting sketch in Adafruit_DACX578/examples/dac7578_sinewaves

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit 313dba2 into arduino:main Feb 15, 2025
11 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/adafruit/Adafruit_DACX578/

github-actions bot pushed a commit that referenced this pull request Feb 15, 2025
@BlitzCityDIY BlitzCityDIY deleted the dacx578 branch February 15, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant