Skip to content

Update repositories.txt #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Update repositories.txt #6014

merged 2 commits into from
Mar 7, 2025

Conversation

dzalf
Copy link
Contributor

@dzalf dzalf commented Mar 5, 2025

Please add my latest libary to communicate with UID/EID EEPROM devices

Thanks for your consideration

🍻

Copy link
Contributor

github-actions bot commented Mar 5, 2025

A problem was found with your submission https://github.com/dzalf/EEPROM_UID

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @dzalf
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dzalf. Thanks for your interest in contributing to the Arduino Library Manager.

I see the bot reported a problem with your submission that will block its acceptance:

A problem was found with your submission https://github.com/dzalf/EEPROM_UID

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Create a new release or tag in the library repository.
  2. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 self-assigned this Mar 5, 2025
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Mar 5, 2025
@dzalf
Copy link
Contributor Author

dzalf commented Mar 5, 2025

Hello @dzalf. Thanks for your interest in contributing to the Arduino Library Manager.

I see the bot reported a problem with your submission that will block its acceptance:

A problem was found with your submission https://github.com/dzalf/EEPROM_UID
ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Create a new release or tag in the library repository.
  2. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

Thanks, @per1234

Working on it at the moment. I will update my repo soon

Cheers

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

A problem was found with your submission https://github.com/dzalf/EEPROM_UID

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @dzalf
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@dzalf
Copy link
Contributor Author

dzalf commented Mar 5, 2025

@ArduinoBot

The repo has been updated!

🍻

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

ERROR: Arduino Lint found errors with https://github.com/dzalf/EEPROM_UID:

Linting library in EEPROM_UID
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (EEPROM_UID.h). Best practices are for primary header filename to match
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in EEPROM_UID/examples/Full_Showcase

Linter results for project: no errors or warnings

-------------------

Linting sketch in EEPROM_UID/examples/Read_UID

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @dzalf
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@dzalf
Copy link
Contributor Author

dzalf commented Mar 5, 2025

@per1234

It turns out that I submitted my library to the PlatformIO package manager, which uses an include and src folders to hold the header and source file, respectively. This is contrary to Arduino standards. I may have to create a second repository to comply with the Arduino file organization, however, I was not aware of this, and I may not have time to do this.

@per1234
Copy link
Contributor

per1234 commented Mar 5, 2025

@dzalf PlatformIO supports the Arduino library format, and in fact thousands of such libraries are in the PlatformIO library registry. So if you change your library to the Arduino format, it will continue to be compatible with PlatformIO. Thus there is no need for you to maintain two repositories.

@dzalf
Copy link
Contributor Author

dzalf commented Mar 7, 2025

@ArduinoBot

The repo has been updated! (again)

🍻

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/dzalf/EEPROM_UID:

Linting library in EEPROM_UID
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in EEPROM_UID/examples/Full_Showcase

Linter results for project: no errors or warnings

-------------------

Linting sketch in EEPROM_UID/examples/Read_UID

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

Copy link
Contributor

github-actions bot commented Mar 7, 2025

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 March 7, 2025 07:52
@dzalf
Copy link
Contributor Author

dzalf commented Mar 7, 2025

@per1234

I don't know what the merge conflict the bot is referring to. I do not see any merge conflict on my repo.

Any pointers?

Cheers

@github-actions github-actions bot removed the request for review from per1234 March 7, 2025 08:08
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/dzalf/EEPROM_UID:

Linting library in EEPROM_UID
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in EEPROM_UID/examples/Full_Showcase

Linter results for project: no errors or warnings

-------------------

Linting sketch in EEPROM_UID/examples/Read_UID

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 7b84f3c into arduino:main Mar 7, 2025
11 checks passed
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/dzalf/EEPROM_UID/

github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
@dzalf
Copy link
Contributor Author

dzalf commented Mar 7, 2025

@per1234 Ah, I know now! It was the latest submissions clashing with mine. Sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants