Skip to content

Add qp-arduino #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Add qp-arduino #6045

merged 1 commit into from
Mar 17, 2025

Conversation

peterpolidoro
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 14, 2025
Copy link
Contributor

A problem was found with your submission https://github.com/QuantumLeaps/qp-arduino

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @peterpolidoro
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Mar 14, 2025
@per1234
Copy link
Contributor

per1234 commented Mar 14, 2025

@ArduinoBot please check it again.

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/QuantumLeaps/qp-arduino:

Linting library in qp-arduino
INFO: No header file found matching library name (QP-C__.h). Best practices are for primary header filename to match    
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Prohibited character(s) in library.properties name value: QP-C++                                      
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in qp-arduino/examples/blinky-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/blinky2-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/blinky_bsp-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/blinky_bsp-teensy4

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/dpp_bsp-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/dpp_bsp-teensy4

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @per1234
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @peterpolidoro. Thanks for your interest in contributing to the Arduino Library Manager.

I see the bot reported a problem with your submission that will block its acceptance:

ERROR: Prohibited character(s) in library.properties name value: QP-C++                                      
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Change the name property in the library's library.properties metadata file to a value that is compliant with the Arduino Library Specification:
    https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
  2. Bump the value of the version property in library.properties.
  3. Create a new release or tag in the library repository.
  4. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Mar 14, 2025
@peterpolidoro
Copy link
Contributor Author

@ArduinoBot please check it again.

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Mar 17, 2025
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/QuantumLeaps/qp-arduino:

Linting library in qp-arduino
INFO: No header file found matching library name (qp-arduino.h). Best practices are for primary header filename to match
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Library name qp-arduino contains "Arduino". This is superfluous.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in qp-arduino/examples/blinky-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/blinky2-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/blinky_bsp-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/blinky_bsp-teensy4

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/dpp_bsp-sam

Linter results for project: no errors or warnings

-------------------

Linting sketch in qp-arduino/examples/dpp_bsp-teensy4

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 8eb2e08 into arduino:main Mar 17, 2025
14 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/QuantumLeaps/qp-arduino/

github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants