Skip to content

ADD https://github.com/manzarehassin/DS1307RTC #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

manzarehassin
Copy link
Contributor

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 23, 2025
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/manzarehassin/DS1307RTC:

Linting library in DS1307RTC
INFO: No header file found matching library name (DS1307RTC.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name DS1307RTC is in use by a library in the Library Manager index. Each library must have a unique name 
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in DS1307RTC/examples/NVRAM_ReadWrite

Linter results for project: no errors or warnings

-------------------

Linting sketch in DS1307RTC/examples/RTC_1Hz_Blink_24hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linting sketch in DS1307RTC/examples/TimeSet_12hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @manzarehassin
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@manzarehassin
Copy link
Contributor Author

@ArduinoBot please recheck

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/manzarehassin/DS1307RTC:

Linting library in DS1307RTC
INFO: No header file found matching library name (DS1307RTC.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name DS1307RTC is in use by a library in the Library Manager index. Each library must have a unique name 
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in DS1307RTC/examples/NVRAM_ReadWrite

Linter results for project: no errors or warnings

-------------------

Linting sketch in DS1307RTC/examples/RTC_1Hz_Blink_24hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linting sketch in DS1307RTC/examples/TimeSet_12hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @manzarehassin
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manzarehassin. The library name the bot is referring to is the name property in the library's library.properties metadata file:

https://github.com/manzarehassin/tinyRTCds1307/blob/main/library.properties#L1

name=DS1307RTC

Although it is a good idea to make the name of your GitHub repository match the name of the library, the bot doesn't care at all what your repository is named, so changing the repository name alone will never fix the error reported by the bot.

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Change the value of the name property to a name that is not already claimed by another library.
    You can search in the Arduino IDE Library Manager for your prospective names to check whether they are taken.
  2. Bump the value of the version field in the library's library.properties metadata file.
  3. Create a new release or tag in the library repository.
  4. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 self-assigned this Mar 23, 2025
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants