Skip to content

add https://github.com/manzarehassin/tinyRTCds1307 #6097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

manzarehassin
Copy link
Contributor

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 23, 2025
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/manzarehassin/tinyRTCds1307:

Linting library in tinyRTCds1307
INFO: No header file found matching library name (DS1307RTC.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name DS1307RTC is in use by a library in the Library Manager index. Each library must have a unique name 
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in tinyRTCds1307/examples/NVRAM_ReadWrite

Linter results for project: no errors or warnings

-------------------

Linting sketch in tinyRTCds1307/examples/RTC_1Hz_Blink_24hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linting sketch in tinyRTCds1307/examples/TimeSet_12hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @manzarehassin
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@manzarehassin
Copy link
Contributor Author

I've changed the library name, class name, library properties file. Please recheck manually.

@manzarehassin
Copy link
Contributor Author

@ArduinoBot kindly recheck

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/manzarehassin/tinyRTCds1307:

Linting library in tinyRTCds1307
INFO: No header file found matching library name (DS1307RTC.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name DS1307RTC is in use by a library in the Library Manager index. Each library must have a unique name 
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in tinyRTCds1307/examples/NVRAM_ReadWrite

Linter results for project: no errors or warnings

-------------------

Linting sketch in tinyRTCds1307/examples/RTC_1Hz_Blink_24hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linting sketch in tinyRTCds1307/examples/TimeSet_12hr_Weekday

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @manzarehassin
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @manzarehassin. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/manzarehassin/tinyRTCds1307/blob/version1_0_0/library.properties#L1

name=DS1307RTC

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 self-assigned this Mar 23, 2025
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Mar 23, 2025
@manzarehassin
Copy link
Contributor Author

@ArduinoBot kindly recheck again

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Mar 23, 2025
@github-actions github-actions bot merged commit d274a18 into arduino:main Mar 23, 2025
14 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/manzarehassin/tinyRTCds1307/

github-actions bot pushed a commit that referenced this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants