Fix (**) and use property tests for Floating #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation of (**) relied on log and incorrectly handled some inputs. The fix is making an explicit implementation using the pow function. To test the changes, tests for functions from the Floating typeclass are re-written using property tests. There are a few helper functions to make writing the actual properties easy. More tests can be converted to properties, but this is left for another PR.
|
This is now rebased on master with #56 merged. |
No this is very exciting, thank you for doing this.
Awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation of (**) relied on log and incorrectly
handled some inputs. The fix is making an explicit implementation
using the pow function.
To test the changes, tests for functions from the Floating typeclass
are re-written using property tests. There are a few helper functions
to make writing the actual properties easy.
More tests can be converted to properties, but this is left for
another PR.
This PR is based on #56. I'll rebase on master once #56 is merged.
P.S. @dmjio I hope you don't mind the frequent PRs. I'm trying to use ArrayFire in a project and fixing/implementing stuff as I encounter problems.