Additional arithmetic ops/traits implementations for Array and &Array #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier to this commit, arithmetic ops/traits were implemented for only &Array type.
Earlier to this change, the arithmetic trait implementations used to call the C-API directly.
jramapuram
requested changes
Feb 15, 2017
src/arith/mod.rs
Outdated
| type Output = Array; | ||
|
|
||
| fn $fn_name(self, rhs: &'a Array) -> Array { | ||
| add(&self, rhs, false) |
There was a problem hiding this comment.
The template always calls add? Did you mean to do something like fn_name ?
There was a problem hiding this comment.
My bad, forgot to replace it with $fn_name after testing with Add trait.
src/arith/mod.rs
Outdated
| type Output = Array; | ||
|
|
||
| fn $fn_name(self, rhs: Array) -> Array { | ||
| add(self, &rhs, false) |
There was a problem hiding this comment.
Same as above comment. arith_func is used for all of these:
arith_func!(Add , add );
arith_func!(Sub , sub );
arith_func!(Mul , mul );
...
jramapuram
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103