Skip to content

Implement (Scalar +-*/ Array) #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Implement (Scalar +-*/ Array) #207

wants to merge 2 commits into from

Conversation

ctrl-z-9000-times
Copy link
Contributor

Hi @9prady9,

I implemented the overloaded operators as you suggested. I don't know what your testing standards are, so I've only done a minimal amount of testing by hand.

Also, it turns out that the function which I previously tried to add (scalar) is already implemented as the convert function, so I could have made the equation 1 / Array work with 1.convert() / Array

I hope this helps!

@9prady9
Copy link
Member

9prady9 commented Dec 6, 2019

Thank you! I don't test full breath of ArrayFire functionality in this wrapper since upstream takes care of it. But I do want to eventually test wrapper calls; Having said that, current tests are doc tests that are written as example codes in each function's documentation - so if you add some example code on how to use the new feature you added. That will check the wrapper call - which should be sufficient for now.

Can you please remove the merge commit. You can avoid such issues if a new feature/bug branch is created on your fork based on upstream's(repo on arrayfire account not your fork) master instead of using your fork's master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants